Divide by zero error on jlayout/uikit

[lcollong]

Hi,

I've got a divide by zero error on line 32 of this file : templates/jp-exchange/html/layouts/com_fabrik/fabrik-bootstrap-grid.php part of the Fabrik-Joomla-alt-layouts uikit I've just downloaded from github.

Actually the code says :

foreach ($d->items as $i => $s)
{
    $endLine = ($i !== 0 && (($i) % $d->columns[1] == 0));
    $newLine = ($i % $d->columns[1] == 0);

But the $d->columns array contains only one key (0, not 1) with a value of 3.
according to the line 15 : $d->columns = (array) $d->columns;
I guess the lines 32/33 should use $d->columns[0] instead of $d->columns[1] ?

 

[cheesegrits]

$d->columns should just be an int.

I've committed a fix.

https://github.com/Fabrik/Fabrik-Joomla-alt-layouts/commit/901320939b3dd0a48993e7039b3da392f81e44e6

-- hugh

 

[lcollong]

it works indeed. But I don't understand ! ;-) Line 15 explicitly build an array and the first "foreach" is going through this array....

Also, but it may be other thing, the checkbox inside the repeated group does not care of the number of cols (see snapshots). Hence, I'm wondering how usefull is to use these jLayouts as it seems to work without ?....

 

[cheesegrits]

Ooops, I hadn't noticed that. Rob must have been experimenting with something. The stuff he was calculating with that code was commented out. And $d->columns is definitely just an int.

I just committed another fix.

-- hugh

 

[lcollong]