notEmpty validation. Real notEmpty?

[gdejesus]

Hello,
There is a bug in notEmpty validation! If you set your field to be validated by notEmpty your field gets validated even if you enter BLANK SPACES!
I made a little mod to fix it

notEmpty.php

/**
* Validate the elements data against the rule
*
* @param string $data To check
* @param int $repeatCounter Repeat group counter
*
* @return bool true if validation passes, false if fails
*/
public function validate($data, $repeatCounter)
{
if (method_exists($this->elementModel, 'dataConsideredEmptyForValidation'))
{
$ok = $this->elementModel->dataConsideredEmptyForValidation($data, $repeatCounter);
$emp = empty($data);
$cf = trim($data);
$emp = empty($cf);
}
else
{
$ok = $this->elementModel->dataConsideredEmpty($data, $repeatCounter);
$cf = trim($data);
$emp = empty($cf);
}
if((!$emp) && (!$ok)):
return !$ok;
endif;
}

Perhaps it is useful for someone.
Bye

 

[gdejesus]

If $data is an array.
if (is_array($data)):
$data = implode ($data);
endif;

 

[Ninpo]

This chart might help determine the right course of action when trying to determine if a value is set or not. It says PHP 7 but it also works on PHP 5.5.

https://www.virendrachandak.com/demos/php-isset-vs-empty-vs-is_null.php