Recent upgrade from J.3.3 to J3.4 plus Fabrik has stopped all emelemnt javascript actions

[p38]

I always hold out as far as possible to update my Fabrik on my sites, because inevitably something breaks.

This time it was no different, a perfectly working site has now broken when I upgraded from J3.3.6 to J3.4 and the latest Git fabrik.

All my element javascript actions have now stopped working. (onchange, onload, onfocus etc etc)

Also I discovered my fileupload element, once the file has uploaded, does not post the record, instead, it comes back blank, url unchanged.

All caches have been cleared etc etc.

Any idea where I can look to problem solve?

Thanks

Paul

 

[troester]

I can't replicate.
Check with a browser dev tool for JS errors.

 

[p38]

Thanks Troester,

TypeError: this.element.getElement(...) is null

http://aes-rms.info/plugins/fabrik_element/databasejoin/databasejoin-min.js
Line 2

I am using cascadeelements as well as dbjoins

Is it not related to this gitupdate 10 hours ago by Rob?

https://github.com/Fabrik/fabrik/commit/98e448f6cdd730c28b08201ded4b77a9e873a03a

It is about "chxTmplNode", which is where the JS is stopping with an error

 

[p38]

Hi Troester,

I can confirm this error occurs when I use a dbjoin or cascadingdropdown, with the checkbox list option

A normal dropdown option works OK.

This bug has crept in recently, as it was working perfectly with a github update of a few months ago.

Paul.

 

[troester]

Hmm, dbjoin.js is doing

    getCheckboxTmplNode: function () {
        if (Fabrik.bootstrapped) {
            this.chxTmplNode = jQuery(Fabrik.jLayouts['fabrik-element-databasejoin-form-checkbox'])[0];
        } else {
            if (!this.chxTmplNode && this.options.displayType === 'checkbox')
            {
                var chxs = this.element.getElements('> .fabrik_subelement');
                if (chxs.length === 0) {
                    this.chxTmplNode = this.element.getElement('.chxTmplNode').getChildren()[0].clone();
                    this.element.getElement('.chxTmplNode').destroy();
                } else {
                    this.chxTmplNode = chxs.getLast().clone();
                }
            }
        }

so it shouldn't run the "this.element.getElement('.chxTmplNode')" in Joomla3+ (and it doesn't on my site).
But I don't know where Fabrik.bootstrapped is set.

 

[p38]

thank you, this sounds feasible, and I suspect something to do with new jLayouts being implemented I read somewhere.

I will see if I can get an old copy of dbjoin.js, just so I can get my site back running again.

 

[p38]

looks like the normal dbjoin is also broken when using checkboxes........ they do not get saved.

Sigh..... 1step forward 2 steps back...... gonna have to restore backup.

Not sure how I can lodge this as a bug, it is unusable in it's present form

 

[troester]

I didn't test the CDD but dbjoin as checkbox.
The checked values are saved but not displayed on edit because "checked" is missing.
https://github.com/Fabrik/fabrik/pull/1549

 

[p38]

I copied the dbjoin and CDD elements from my Github uppdates archive 4th August and can confirm it all works OK.

So between then and now, things went pearshaped.

Doing a compare of source code in the JS, there were substantial changes done, esp regards to checkboxes

 

[rob]

I've hopefully had a go at fixing those with this commit
https://github.com/Fabrik/fabrik/commit/f84618b822bf83fbd435bbd0c7ff7c3118d245ff

 

[p38]

thanks Rob, I will test it out.

Paul