"contains" condition in js tabs - bug or feature ?

[lcollong]

Hi,

I have a regular field element with js action show/hide on to another element.
I'd like to use "contains" and "!contains" in the condition. The js value field is set to the word "option" (without the quotes as it messed up the relevant fabrik_element row). The "contains" action is executed if the field value is exactly "option". But if it is set to "optionnel" or "options" then the action never take place. I thought that contains means "if substring is in string" ? Looks like a pure "==". Is this normal behavior or a bug ?

 

[rob]

ah yes, it was matching a single value from a array (so would work well for say a checkbox item) but obviously not work well if you were testinig against a string.
I've updated the code in github to manage both scenarios

-Rob

 

[lcollong]

Thanks Rob. In order to test it, would you consider replicate your fix in the "master" branch of git ?

 

[rob]

hehe oups yes would be good if I fixed it there as well wouldn't it! ?
I've done that now !

-Rob

 

[lcollong]

Thanks

 

[lcollong]

Tested ! Works very well indeed. Closing this one.