I'm convinced I am jinxed and there really is a 'Phil's Law' - i.e if something can go wrong, it will.
This morning I went to respond to a notice in my email re a response from troester regarding a forum post I made late last night. It was good way to start my day because she gave me a pat on the back for my efforts... "Looks nice".
In that post I thanked Rob for fixing the issue where the list CSV params were not being set as the 'Front end option' defaults. That was the good news.
But I also detailed all the other issues I still found with the CSV Export popup after updating from github yesterday afternoon. I also promised to post my changes at Github (which I did right after I started the thread here in the Community forum). At github, I suggested that the powers-that-be should review that thread for details of the changes, and why they were made.
Well, I couldn't respond to troester - because the fabrikar server was down - and now that it's come back I see everything was lost. So there is nothing for Rob or Hugh to reference regarding my github changes. So here I go again.
Normally I compose my posts in a text editor then cut and paste - and I did that for that particular post also, but for some reason I just cut and pasted it without saving it to my pc. THAT is "Phil's Law".
Anyhow, I can't even remember exactly all I wrote, as it was quite detailed and took me all evening to compose - but I'll try an abbreviated version. And the good news is I still have the screen-snip attachments that I had included.
See the first image, which is what the popup looked like after the github update (csvpopupAsIs.PNG) - and note how the formatting is off.
Also the way the popup window is now - it is no longer movable or resizeable - and if I open the Chrome developer toolbar the toolbar overwrites the bottom half of the popup window - and I can't even see or click the submit (Export) button or even move the popup form. (Just wondered what was wrong with the old style used for the popup and why it needed to be changed.
The code I posted at github late last night produces the popup looking like the attached image (latestChangesCSVExport.PNG) - and will prevent what is happening in that first image from happening again - and fixes the issues that still exits with the submit button ('Export') and the Download button - so that when you click the Export button the form options and the Export button are immediately hidden - and when you click the download button it is immediately hidden (so you can't click it again). Rob told me he fixed that but the latest changes still allowed the download button to be clicked multiple times (as it still didn't hide the Download button until the popup lost focus). So you could still click it again - and when you do, instead of an error as used to occur (because the file had just been deleted), the downloaded file was instead downloaded again - but it is a blank CSV file (which IMO is worst, or more confusing to the end-user, than getting the error).
I give up trying to re-invent the wheel all at once. So am pushing for just one change at at time. Hopefully the code I posted last night will get pulled into the Fabrik core and stop me from having to repeatedly re-tweak that popup every time I update from github.
Today I just added and tested some code for specifying the desired popup width for the List CSV Export Front end options - and will try to pass that onto github too, once I get past this hurdle. I did that because the element labels can be quite long in some cases and would need to word-wrap in that form. I see no reason why the width of that popup should be hard-coded and limited when there is so much horizontal space available on the screen.
This morning I went to respond to a notice in my email re a response from troester regarding a forum post I made late last night. It was good way to start my day because she gave me a pat on the back for my efforts... "Looks nice".
In that post I thanked Rob for fixing the issue where the list CSV params were not being set as the 'Front end option' defaults. That was the good news.
But I also detailed all the other issues I still found with the CSV Export popup after updating from github yesterday afternoon. I also promised to post my changes at Github (which I did right after I started the thread here in the Community forum). At github, I suggested that the powers-that-be should review that thread for details of the changes, and why they were made.
Well, I couldn't respond to troester - because the fabrikar server was down - and now that it's come back I see everything was lost. So there is nothing for Rob or Hugh to reference regarding my github changes. So here I go again.
Normally I compose my posts in a text editor then cut and paste - and I did that for that particular post also, but for some reason I just cut and pasted it without saving it to my pc. THAT is "Phil's Law".
Anyhow, I can't even remember exactly all I wrote, as it was quite detailed and took me all evening to compose - but I'll try an abbreviated version. And the good news is I still have the screen-snip attachments that I had included.
See the first image, which is what the popup looked like after the github update (csvpopupAsIs.PNG) - and note how the formatting is off.
Also the way the popup window is now - it is no longer movable or resizeable - and if I open the Chrome developer toolbar the toolbar overwrites the bottom half of the popup window - and I can't even see or click the submit (Export) button or even move the popup form. (Just wondered what was wrong with the old style used for the popup and why it needed to be changed.
The code I posted at github late last night produces the popup looking like the attached image (latestChangesCSVExport.PNG) - and will prevent what is happening in that first image from happening again - and fixes the issues that still exits with the submit button ('Export') and the Download button - so that when you click the Export button the form options and the Export button are immediately hidden - and when you click the download button it is immediately hidden (so you can't click it again). Rob told me he fixed that but the latest changes still allowed the download button to be clicked multiple times (as it still didn't hide the Download button until the popup lost focus). So you could still click it again - and when you do, instead of an error as used to occur (because the file had just been deleted), the downloaded file was instead downloaded again - but it is a blank CSV file (which IMO is worst, or more confusing to the end-user, than getting the error).
I give up trying to re-invent the wheel all at once. So am pushing for just one change at at time. Hopefully the code I posted last night will get pulled into the Fabrik core and stop me from having to repeatedly re-tweak that popup every time I update from github.
Today I just added and tested some code for specifying the desired popup width for the List CSV Export Front end options - and will try to pass that onto github too, once I get past this hurdle. I did that because the element labels can be quite long in some cases and would need to word-wrap in that form. I see no reason why the width of that popup should be hard-coded and limited when there is so much horizontal space available on the screen.
Attachments
Last edited: