@Sophist
I'm going to say this one more time, as you obviously didn't process it when I told you months ago in Skype. The 3.x code is in maintenance mode, until I get more of a handle on the 4.0 code, which is what I'm having to spend pretty much all my dev time on. That means only essential bug fixes, or features I need to add for paying clients (which I know won't be problematic to merge into the 4.0 code) are going in 3.x at the moment (plus a few changes I'm doing for my own projects, which may happen to overlap with requests on the forums).
Once I have a better handle on the 4.0 code, and have fully merged all the changes to date since it was branched, I'll start merging your PR's again.
As for the specific form.js one you are upset about, and messaged us yesterday about how I "trashed" it our of "disrespect" - no, I made a small change to form.js, but a bug in a new release of my IDE caused it to commit with changes to every line ending, so now cannot be automatically merged, and needs to be "deconflicted" by you merging changes back to your branch. This didn't just bite me, it bit thousands of devs, and IntelliJ released a patch within 24 hours. This is just a part of life doing cross platform development with git. Occasionally shit goes sideways.
And, as an aside, the process you will need to go through with that one PR is pretty much the process I'll have to go through with every change you make that touches code I've had to modify in 4.0 when I merge them downstream. Welcome to my world, and perhaps now you have a better understanding of why I'm reluctant to merge stuff until I've made more progress on 4.0, and can take a few days to go through the tedious process of merging conflicting changes.
This isn't open for debate. I'll simply delete any confrontational responses.
-- hugh
