"update column"-list plugin - don't work {placeholders}

[blue-mouse]

Hi,
I try on list plugin "update column" write html code with placeholders:
PLG_LIST_UPDATE_COL_UPDATE_EMAIL_MSG_LABEL:

Akceptacja koszt?w:
Klient: {ccjom_cc_klienci_zgl_naprawy___akceptujacy}<br/>
------------------------------------------------------------<br/>
Zg?oszenie nr:C&C/{ccjom_cc_klienci_zgl_naprawy___id}<br/>
Wst?pna cena us?ugi serwisowej:{ccjom_cc_klienci_zgl_naprawy___wstepna_wycena}<br/>
Urz?dzenie: {ccjom_cc_klienci_zgl_naprawy___urzadz_razem} nr ser.: {ccjom_cc_klienci_zgl_naprawy___urzadz_num}<br/>
--------------------------------------------------------------<br/>

this paceholders don't work at all in received email text,

Is possible to make them working ?

 

[cheesegrits]

I'm working on this one, but I've gotten side tracked in to fixing an update_col issue in 3.1. I didn't notice you were posting in 3.0, tried replicating this issue in 3.1, and ran in to a rather nasty SQL query bug in the 3.1 email sending process for this plugin, which I have to fix as a priority.

As soon as I get that fixed, I'll get back to testing your issue with the 3.0 code.

-- hugh

 

[jo-ka]

Hello Cheesegrits.

I don't know if you also detected this behavior in the plugin email function. Besides the placeholders are not working, if you have for example 4 options set in the list for update_col plugin, all the email notifications are sent with the data and the details of the last created option.

Did you noticed this?

BR.

 

[rob]

can you post a screen shot of your update column settings and what is being selected in the front end and the emails it generates?

 

[cheesegrits]

I don't seem to be able to replicate this problem. My emails are going out with the placeholders correctly filled in.

Here's a quick Jing video showing my update_col setup, the three rows I tested with, and the emails I received.

blue-mouse - are the elements you are using plceholders for on a joined table, or the main table for the list? What element types are they?

I'm testing with just simple field elements, on the main table.

It might help if one or both of you could create a really simple test list, with just a couple of field elements, and see if that works. It could be something specific to your list setup.

Oh, and of course make sure you are running the latest code.

http://screencast.com/t/0JdJd13N4FF

if you have for example 4 options set in the list for update_col plugin, all the email notifications are sent with the data and the details of the last created option.

Not sure what you mean? Can you explain in more depth, or use screeshots or a Jing video to illustrate the problem?

-- hugh

 

[jo-ka]

ok, i'll try to save a screencast...

 

[blue-mouse]

blue-mouse - are the elements you are using plceholders for on a joined table, or the main table for the list? What element types are they?
types of elements are: field, internalid, user - nothing don't work
But i use GitHub 19Dec 2013, i will try update on early morning becouse we now use some forms in office and i can't update during office day,

This plugin updates field: 'akceptacja_koszt1' with value 'akceptacja'

 

[blue-mouse]

I have updated today on GitHub and still is the same - {placeholders} doesn't work even for simple type "field" of element.
screen shot with my email,

 

[blue-mouse]

link to list: http://candc.katowice.pl/index.php/...klienci-adm-akceptacja-kosztow-napr-pracownik
option: "Zaakceptuj koszty naprawy"

list in admin panel:
http://candc.katowice.pl/administrator/index.php?option=com_fabrik&view=list&layout=edit&id=218

 

[cheesegrits]

I still can't replicate this. I tried on a more complex test form, with several different element types, and it works for me.

Probably won't work, but just in case ... can you try using a short name, without the table___ prefix? Like just {urzadz_num}.

-- hugh

 

[blue-mouse]

This short name also doesn't work for me,

 

[cheesegrits]

OK, then let's try and debug this ... can you edit ./plugins/fabrik_list/update_col/update_col.php, at line 282 should be this:

if (JMailHelper::cleanAddress($to) && FabrikWorker::isEmail($to))
{
    $thissubject = $w->parseMessageForPlaceholder($subject, $row);
    $thismessage = $w->parseMessageForPlaceholder($message, $row);

Can you put a var_dump() in there so we can see what is in $row, which should be the list data for the first row being updated:

if (JMailHelper::cleanAddress($to) && FabrikWorker::isEmail($to))
{
    var_dump($row);exit;
    $thissubject = $w->parseMessageForPlaceholder($subject, $row);
    $thismessage = $w->parseMessageForPlaceholder($message, $row);

This should dump something looking like this to the browser when you test the plugin:

http://screencast.com/t/ETGSLeHcuVLz

Copy and paste here whatever shows up.

-- hugh

 

[jo-ka]

Hello All. Sorry for the late reply but i had only some time this morning.

Please check this 2 screencasts where you can see what is happening in my system.

http://screencast.com/t/4gY3uSptck (part 1)

http://screencast.com/t/oA0OJcL5lG4 (part 2)

I must say again that i'm using Joomla 2.5.17 and Fabrik 3.1RC2

 

[troester]

I can confirm jo-ka's issue for Fabrik3.1 (latest Git) on J!3.2, too.
But I have opened a new thread to avoid confusion with different issues.
http://www.fabrikar.com/forums/index.php?threads/multiple-update_cols-wrong-email-sent.37509/

 

[jo-ka]

I'm sorry for the confusion and thank you for opening a new thread.

But also the placeholder issues still persists, right?

 

[troester]

Tested with Fabrik3.1 (GitHub) on J!2.5: placeholders are working
Are you running a recent GitHub version (joomla3 branch if you are on Fabrik3.1)?

 

[jo-ka]

Yes i think so. Remember that i have joined tables and not placeholders from a direct table.

 

[jo-ka]

Hello.
I saw that 4 hour's ago this problem (http://www.fabrikar.com/forums/index.php?threads/multiple-update_cols-wrong-email-sent.37509/) was solved.

I still have the problem with the paceholders and joined tables in List emails. Can i help in any way to find a solution?

 

[cheesegrits]

Looking at this now, see if I can replicate the issue with joined data.

-- hugh

 

[cheesegrits]

I can see one issue with joined elements, which is that if it's a repeated join, not merged, and you have more than one joined row (so 'parent' and 'child 1', 'child 2') and you select both parent rows for update, you are only going to get the value of the first one in your email. That's because update_col is only using the id for the parent row, so it only sees one row to update.

However, if you have elected to merge repeat joins, the placeholder for the joined element should have both child row values, formatted in whatever the default representation the element type uses (usually an unnumbered list).

How are your joins configured? I started watching your video, but it doesn't seem to have sound, and I was getting somewhat confused.

-- hugh