Elements Show in List not filtering for Yes and No

[felixkat]

As per title.

\administrator\components\com_fabrik\models\elements around line 113 needs to be change from

       $showInList = $this->getState('filter.showinlist');

       if (!empty($showinlist) && !empty(trim($showInList)))
       {
           $query->where('e.show_in_list_summary = ' . (int) $showInList);
       }

To what it was before.

       $showInList = ($this->getState('filter.showinlist'));

       if (trim($showInList) !== '')
       {
           $query->where('e.show_in_list_summary = ' . (int) $showInList);
       }

Empty is ignoring the "no" state as it's a zero.

Need to make sure variable name is $showInList

 

[achartier]

I have made that change to the repo. It will be in the next release.

It amazes me the number of things like this that still exist in a project as old as it is.

 

[felixkat]

I have made that change to the repo. It will be in the next release.

It amazes me the number of things like this that still exist in a project as old as it is.

It brings back old memories when I was spotting these going to Fabrik 2 (although I think in this case it may have been a recent typo going to J4)

None of the ordering options are working for Fabrik Groups either. I've put it on my list of things to look at.

 

[troester]

It's definitivly working in F3 (even with php8), so yes, probably some F4 typo.

 

[felixkat]

It's definitivly working in F3 (even with php8), so yes, probably some F4 typo.

For the "elements show in list" it was a typo duting the F4 changes.

Not sure about the groups one though. I've compared the changes between f3 and f4 and there's nothing that stands out that should cause an issue. I will look at it though.

 

[troester]

Group sortings:
In administrator\components\com_fabrik\views\groups\tmpl\bootstrap.php replace
HTMLHelper::_('searchtools.sort'
with
HTMLHelper::_('grid.sort'

 

[felixkat]

Group sortings:
In administrator\components\com_fabrik\views\groups\tmpl\bootstrap.php replace
HTMLHelper::_('searchtools.sort'
with
HTMLHelper::_('grid.sort'

Oooo okay, I'll have a look. I didn't look at the templates.