Problems with user only edit forms

[calmdevil]

Hello, I repeat a topic from Testing:
http://fabrikar.com/forums/showthread.php?t=27396
It was bumped up, but, may be here it'll more quickly.

Intro:
list with two elements (apart from id and date_time):
el1: plugin 'user', User Data 'User Name'
el2: plugin 'field'
In list settings access:
View list - Public
View records - Public
Edit records - Special
or use field: el1

Problem:
on the site in list view I get Edit button only for current logged in user (all right), but after push Edit user redirects to view form with Fabric notice: "Can't edit records".
Whats wrong?

 

[cheesegrits]

i don't seem to be able to duplicate this one.

What is the exact wording of the notice? That will help me work out exactly where in the code that is happening.

-- hugh

 

[calmdevil]

There is not a translation in Russian and I translated it as I understand.
Really: COM_FABRIK_NOTICE_CANT_EDIT_RECORDS="Sorry, but you are not authorised to edit this record"

 

[troester]

I can confirm this:
List access settings
edit xx or use field
If the user has only access via "or use field" the edit icon is showing in list view but clicking on it will show the details view with the message

 

[rob]

ah ok yes, we hadn't loaded up the form's data before doing the acl test - so it failed when comparing the records data against the current logged in user.

This should be fixed in github

-Rob

 

[troester]

Hi Rob,
are you sure it is commited?
I can't see a difference (and no commit which would fit).

 

[calmdevil]

O... no...
The problem is not solved! Sorry!

 

[cheesegrits]

OK, like Troester, I don't see a commit from today which would address this issue. Rob must have forgotten to push the changes up to github, or didn't notice a push failure.

I'll ping him about this when he gets online.

-- hugh

 

[calmdevil]

Friendly bump

 

[rob]

commit was
https://github.com/Fabrik/fabrik/commit/90e6748583edb3eaf4cf0cbbb1634beb91ded26f

are you sure this isn't working?

 

[troester]

It seems to be ok now.

But I'm pretty sure this commit was not included in GitHub until today;
I couldn't find it in my GitGui from yesterday (same with the two commits before this one) but decided to do a new fetch before creating a screenshot, and there is was (6 days ago).
So it seems there was something mixed up in the GitHub.

 

[calmdevil]

Yes, sorry, I have missed update. All works fine!
Thank you!