List "Order by" Issue

[rackem]

I have a list with an element set to "allow ordering" in the list view settings. The "order by" setting for the list is set to by "id" descending.

The list displays correctly at first (by "id" descending). Then I click the column link to cycle through the element's ordering (ascending, descending, off). The issue is that the list setting is not maintained when the element ordering gets to off. Now the list is ordered by "id" ascending.

You can see the issue by cycling the ordering on the "Effect on Rating" column here:

http://www.mypoolstats.com/index.ph..._raw=29&mpsV_match_diff_10___rating_id_raw=10

Note the "id" column won't normally be displayed but it is on to help illustrate the issue.

 

[cheesegrits]

https://github.com/Fabrik/fabrik/commit/cf3cc9176eb6500d2f86ccb03a6705cadc28dff6

Ignore the commit comment.

-- hugh

 

[rackem]

Hmm, after updating from Github, cycling the ordering to off doesn't change the sort from the previous state.

Here is the last part of the queries returned when using &fabrikdebug=1

Click on link: ...ORDER BY `mpsV_match_diff_10`.`id` DESC
Cycle 1: ...ORDER BY `mpsV_match_diff_10___plyr_diff_10` asc
Cycle 2: ...ORDER BY `mpsV_match_diff_10___plyr_diff_10` desc
Cycle 3 (should be off): ...ORDER BY `mpsV_match_diff_10`.`plyr_diff_10` DESC

The highlighted text should be `id`.

 

[cheesegrits]

OK, try this:

https://github.com/Fabrik/fabrik/commit/8280a7944ea157b420d5125ea2e30a3e6a3028d1

-- hugh

 

[rackem]

That fixes it! Thank you Hugh!