Minor Bug: superfluous li tag in heading actions dropdown in list view

Status
Not open for further replies.

VOI

Member
Hi,

I have set "Render buttons as" in the list properties to "Dropdown" for some of my lists.

In this case, the HTML code to generate the buttons for any list PHP plugins seem to have a superfluous opening and closing <li> tag.

This is causing the HTML validator in the IE Devtools to show an error message stating that there are missing end tags.
I had a look at the following file
\components\com_fabrik\models\list.php
I believe the lines causing this additional, but not required li tag are lines 6903ff
Code:
foreach ($res as &$r)
{
     $r = $this->actionMethod() == 'dropdown' ? '<li>' . $r . '</li>' : $r;
}

The helper function FabrikHelperHTML::bootStrapButtonGroup called in line 6923 already adds li tags around every link.
I commentend the lines 6903-6905 out - and the HTML validation error is gone.
Not sure is this additional li tag is required in any corner causes.
Chris
 
Status
Not open for further replies.
We are in need of some funding.
More details.

Thank you.

Members online

Back
Top