Update databasejoin element data in repeat group on form submit

[startpoint]

Hi,
I tried to update value with following code:

$v = array('test');
$formModel->formData['table___element_name']=$v;
$formModel->formData['table___element_name_raw']=$v;

or

$v = array('test');
$formModel->updateFormData('table___element_name'), $v, true;
$formModel->updateFormData('table___element_name_raw'), $v, true;

This code run in php form plugin during Start on form submission (onBeforeProcess).
The value in database not updated.
The result is the same when code run from php file.
If element is simple field the value updated successfully.

Tested on Joomla 3.8.3 and latest github update.
Where is my mistake or have a bug?

 

[cheesegrits]

Try ...

$v=array('test');
$formModel->updateFormData('table___element_name' , $v, true);

... so that's 3 args to the updateFormData() method.

The last one says "also set the _raw to this", so no need to explicitly update the _raw as well.

-- hugh

 

[cheesegrits]

Oh, just noticed the subject says "database join". In which case you'll need to use the value, not the label. So ...

$v=array('123');

... or whatever the FK value is for that.

-- hugh

 

[startpoint]

I made a mistake by writing the code here and forgetting to mention that the element is in a repeating group.
This is a actual code:

$v=array('1');
//$v=array(array('1'));
$formModel->updateFormData('repeat_group___dbjoin_elem' , $v, true);

Again not working.

 

[cheesegrits]

If it's a repeat element, the formdata entry itself will be an array, with as many entries as there are repeats.

-- hugh

 

[startpoint]

That's exactly how I'm testing even with one line is not updated again.
This is a video with the value before and after my update, but after the form has been saved, the update has not happened.
https://www.screencast.com/t/2ozhO6JU
What is wrong?

Update:
I make another video with 2 rows in repeated group.
https://www.screencast.com/t/PZJiu9JOj3rQ

I hope to help fix the problem.

 

[startpoint]

Friendly Bump

 

[startpoint]

Friendly Bump

 

[startpoint]

Hugh, can you help me with right code to update elements?

 

[startpoint]

Friendly Bump!

 

[cheesegrits]

OK, I've narrowed down what's going on, but it's not an entirely trivial fix. It'd be nice if you could take out a sub for the month to help out with the time needed to resolve it. I'll probably fix it anyway, but ... gotta pay the bills somehow ...

-- hugh

 

[startpoint]

Payment is complete.

 

[cheesegrits]

Thanks!

And here's your fix:

https://github.com/Fabrik/fabrik/commit/d87eb7a78e1da0511fe68eee64ec68d108b58720

... which may look like a tiny change, but took quite a while to figure out what was going on, and find a minimalistic fix for it.

-- hugh

 

[startpoint]

Thanks for the quick response.
I will test and tell the result.